Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not submit] Add model digest #131

Closed
wants to merge 2 commits into from
Closed

[Do not submit] Add model digest #131

wants to merge 2 commits into from

Conversation

jakemac53
Copy link
Contributor

@jakemac53 jakemac53 commented Nov 1, 2024

I created this simplified version of a model digest mostly out of curiosity to see if it could actually work, and it turns out it doesn't :). The test fails because the digests are different.

I think that just hashing the raw bytes can never really be relied upon because of all the pointers in the bytes - unless it is built in exactly the same order the bytes will inevitably be different.

There is another issue that if the Model is a not the root of the buffer, it will capture more information than we want, in particular info that is not hermetic (for instance, request IDs).

So, I think we will need a different approach here.

@jakemac53 jakemac53 marked this pull request as draft November 1, 2024 16:23
@jakemac53
Copy link
Contributor Author

cc @davidmorgan

@jakemac53 jakemac53 changed the title [WIP] Add model digest [Do not submit] Add model digest Nov 1, 2024
@jakemac53 jakemac53 closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant